[Asterisk-code-review] channel.c: Fix segfault with Monitor(wav,file,i) (asterisk[16.1])

[Valentin Vidić]

Valentin Vidić has uploaded this change for review. ( https://gerrit.asterisk.org/10892


Change subject: channel.c: Fix segfault with Monitor(wav,file,i)
......................................................................

channel.c: Fix segfault with Monitor(wav,file,i)

If the Monitor is started with the i option the read_stream will be
NULL. One code path in channel.c checks if write_stream is set but than
uses read_stream instead causing a segfault.

ASTERISK-28249

Change-Id: I77a1565f3651338dd61afaef06af0fe09f13b020
---
M main/channel.c
1 file changed, 2 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/92/10892/1

diff --git a/main/channel.c b/main/channel.c
index 6c6e9f7..d4eca55 100644
--- a/main/channel.c
+++ b/main/channel.c
@@ -5260,7 +5260,7 @@
 				if (jump >= 0) {
 					jump = calc_monitor_jump((ast_channel_insmpl(chan) - ast_channel_outsmpl(chan)),
 					                         ast_format_get_sample_rate(f->subclass.format),
-					                         ast_format_get_sample_rate(ast_channel_monitor(chan)->read_stream->fmt->format));
+					                         ast_format_get_sample_rate(ast_channel_monitor(chan)->write_stream->fmt->format));
 					if (ast_seekstream(ast_channel_monitor(chan)->write_stream, jump, SEEK_FORCECUR) == -1) {
 						ast_log(LOG_WARNING, "Failed to perform seek in monitoring write stream, synchronization between the files may be broken\n");
 					}
@@ -5271,7 +5271,7 @@
 #else
 				int jump = calc_monitor_jump((ast_channel_insmpl(chan) - ast_channel_outsmpl(chan)),
 				                             ast_format_get_sample_rate(f->subclass.format),
-				                             ast_format_get_sample_rate(ast_channel_monitor(chan)->read_stream->fmt->format));
+				                             ast_format_get_sample_rate(ast_channel_monitor(chan)->write_stream->fmt->format));
 				if (jump - MONITOR_DELAY >= 0) {
 					if (ast_seekstream(ast_channel_monitor(chan)->write_stream, jump - cur->samples, SEEK_FORCECUR) == -1) {
 						ast_log(LOG_WARNING, "Failed to perform seek in monitoring write stream, synchronization between the files may be broken\n");

-- 
To view, visit https://gerrit.asterisk.org/10892
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16.1
Gerrit-MessageType: newchange
Gerrit-Change-Id: I77a1565f3651338dd61afaef06af0fe09f13b020
Gerrit-Change-Number: 10892
Gerrit-PatchSet: 1
Gerrit-Owner: Valentin Vidić <vvidic at valentin-vidic.from.hr>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190120/f0bf5bb3/attachment.html>