[Asterisk-code-review] pjsip transport management: Shutdown transport immediately o... (asterisk[13])

Sean Bright asteriskteam at digium.com
Fri Jan 18 16:39:14 CST 2019


Hello Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/10886

to look at the new patch set (#3).

Change subject: pjsip_transport_management: Shutdown transport immediately on disconnect
......................................................................

pjsip_transport_management: Shutdown transport immediately on disconnect

The transport management code that checks for idle connections keeps a
reference to PJSIP's transport for IDLE_TIMEOUT milliseconds (32000 by
default). Because of this, if the transport is closed before this
timeout, the idle checking code will keep the transport from actually
being shutdown until the timeout expires.

Rather than passing the AO2 object to the scheduler task, we just pass
its key and look it up when it is time to potentially close the idle
connection. The other transport management code handles cleaning up
everything else for us.

Related to ASTERISK~28231

Change-Id: I02ee9f4073b6abca9169d30c47aa69b5e8ae9afb
---
M res/res_pjsip/pjsip_transport_management.c
1 file changed, 49 insertions(+), 30 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/86/10886/3
-- 
To view, visit https://gerrit.asterisk.org/10886
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I02ee9f4073b6abca9169d30c47aa69b5e8ae9afb
Gerrit-Change-Number: 10886
Gerrit-PatchSet: 3
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation (1000185)
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190118/66e31e16/attachment.html>


More information about the asterisk-code-review mailing list