[Asterisk-code-review] main/cdr: Fixed cdr start overwriting (asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/10747 )

Change subject: main/cdr: Fixed cdr start overwriting
......................................................................


Patch Set 5:

Thanks for the update and testing. I've commented on the issue, but I linked another issue where the user reported a new CDR record was being created once the call entered the dialplan via an AGI called from a queue process. I verified that was the case for that given scenario.

Maybe the solution is to squash the secondary creation, but I am mostly worried about breaking current user expectation (although the user on the linked issue did not expect the new CDR record).

Also I don't know the original intent and reasoning behind the creation of a new CDR record once it re-enters the dialplan (at least for the scenario described for https://issues.asterisk.org/jira/browse/ASTERISK-28152). At the very least can anyone think of a case where it makes sense for a new CDR to be created at that time?

Perhaps more opinions are warranted? Anyone else have thoughts?


-- 
To view, visit https://gerrit.asterisk.org/10747
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I921bc04064b6cff1deb2eea56a94d86489561cdc
Gerrit-Change-Number: 10747
Gerrit-PatchSet: 5
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Thu, 17 Jan 2019 00:04:59 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190116/03d36c9c/attachment.html>