[Asterisk-code-review] main/cdr: Fixed cdr start overwriting (asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/10747 )

Change subject: main/cdr: Fixed cdr start overwriting
......................................................................


Patch Set 5:

> If I understand (possible I misread something) I think this will
 > break expectations. At least according to the documentation. Taking
 > a look at the https://wiki.asterisk.org/wiki/display/AST/Asterisk+12+CDR+Specification.
 > It states the following:
 > 
 > "If a channel dials another channel and then continues on in the
 > dialplan, the CDR for the dial operation is finalized and a new CDR
 > is created.
 > 
 > ... <also> ...
 > 
 > If the caller continues on in the dialplan, a new CDR is generated
 > for them."
 > 
 > Basically I take this to mean that any time a channel enters the
 > dialplan (initially, through continue, returns to, etc...) a new
 > CDR is to be created. I've verified this using an AGI script at
 > least:
 > 
 > 1. Channel enters dialplan = new CDR
 > 2. Channel enters AGI script = same CDR
 > 3. Channel returns to dialplan from AGI = new CDR
 > 
 > From what I can tell that's how it is working, and has been working
 > for quite a while. It seems that this change would break that. I
 > guess the question becomes has it been broken this whole time and
 > is the documentation wrong? Does transitioning from a channel from
 > a some context (ARI, AGI, etc..) warrant a new CDR?

Hi Kevin, I just have atest using the AGI. But for me, it was different. It didn't create new CDR for this. If the AGI is not creating a new CDR as I tested, I think we need to don't create new one.

I've tested with this dialplan.

exten => agi_test,1,NoOp(agi_test)
 same => n,AGI(agi:async,agi_test)
 same => n,Wait(10)
 same => n,Hangup()


And after the channel entered to the AGI, I sent these 2 command using AMI.

Action: AGI
Channel: PJSIP/sipp-uac-00000044
Command: Answer

Action: AGI
Channel: PJSIP/sipp-uac-00000044
Command: asyncagi break 


And here's my test log.
https://issues.asterisk.org/jira/browse/ASTERISK-28181?focusedCommentId=245987&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-245987


-- 
To view, visit https://gerrit.asterisk.org/10747
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I921bc04064b6cff1deb2eea56a94d86489561cdc
Gerrit-Change-Number: 10747
Gerrit-PatchSet: 5
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Wed, 16 Jan 2019 23:12:17 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190116/ccab6b78/attachment-0001.html>