[Asterisk-code-review] res stasis: Auto-create context and add ability to switch ap... (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10882 )

Change subject: res_stasis: Auto-create context and add ability to switch applications.
......................................................................


Patch Set 2:

> > Sorry but would you mind splitting the auto-create context off to
 > a
 > > separate review?  It doesn't seem like the two features are
 > > inter-dependent and I have some concerns that the auto-context
 > > could be a potentially breaking change as is.
 > >
 > > If I have an application 'myprog' that includes an
 > extensions.conf
 > > context 'stasis-myprog', this auto-create feature will merge into
 > > my existing context.  Even if the existing dialplan doesn't have
 > a
 > > '_.' or 'h' extensions this can change the result of
 > > `${DIALPLAN_EXISTS(stasis-myprog,${SOMEEXTEN},1)}` since all
 > > extensions will exist.  My only ideas to avoid this is to make
 > the
 > > feature opt-in or do it in master only.
 > >
 > > FWIW I haven't had a chance to review the code for the 'move'
 > > feature, this -1 is purely on concerns about conflicting with
 > > existing dialplan.
 > 
 > Talked about this with Josh, and he believes they are part of the
 > same issue. Here's what I propose:
 > 
 > For the context creation, if it already exists, don't append the
 > extensions to it and print a WARNING. That way, it shouldn't
 > interfere with anyone's existing dialplan logic, and those that are
 > looking to eliminate dialplan entirely can still work with the
 > auto-creation.

Yes that seems reasonable as long as the dialplan module is loaded before ARI apps connect, but I think that's pretty much guaranteed.


-- 
To view, visit https://gerrit.asterisk.org/10882
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c569468472dbb08905b356887373c81e03015d
Gerrit-Change-Number: 10882
Gerrit-PatchSet: 2
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Comment-Date: Wed, 16 Jan 2019 20:51:57 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190116/a17bb29d/attachment.html>