[Asterisk-code-review] pbx dundi: added support for PJSIP in dundi mappings (asterisk[16])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/10865 )

Change subject: pbx_dundi: added support for PJSIP in dundi mappings
......................................................................


Patch Set 1:

If anyone else is looking for the comment Josh mentions in his first comment, it was this:

> In general, though, I don't think this is the correct approach for supporting PJSIP. This is because unlike other channel drivers you can not simply dial a target at an IP address. As it is this change would only work if an endpoint of that already existed. If it did not, then it would fail.

> I think a configuration option on the side doing the lookup would need to be present to allow a PJSIP endpoint to be specified when constructing the appropriate Dial line.


-- 
To view, visit https://gerrit.asterisk.org/10865
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfd2d7637e25c5c0a5aa1f3254bab641b1bfe133
Gerrit-Change-Number: 10865
Gerrit-PatchSet: 1
Gerrit-Owner: Kirsty Tyerman <kirsty.tyerman at boeing.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Kirsty Tyerman <kirsty.tyerman at boeing.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 15 Jan 2019 22:45:41 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190115/b15cffcb/attachment-0001.html>