[Asterisk-code-review] app voicemail: Add Mailbox Aliases (asterisk[13])

Sean Bright asteriskteam at digium.com
Tue Jan 15 10:44:18 CST 2019


Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/10799 )

Change subject: app_voicemail:  Add Mailbox Aliases
......................................................................


Patch Set 6: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/10799/6/apps/app_voicemail.c
File apps/app_voicemail.c:

https://gerrit.asterisk.org/#/c/10799/6/apps/app_voicemail.c@1780
PS6, Line 1780: 		size_t len = sizeof(vmu->mailbox) + sizeof(vmu->context) + sizeof('@') + 1;
MAX_VM_MAILBOX_LEN?


https://gerrit.asterisk.org/#/c/10799/6/apps/app_voicemail.c@6104
PS6, Line 6104: 		char tmp[256];
MAX_VM_MAILBOX_LEN?



-- 
To view, visit https://gerrit.asterisk.org/10799
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I395b9205c91523a334fe971be0d1de4522067b04
Gerrit-Change-Number: 10799
Gerrit-PatchSet: 6
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 15 Jan 2019 16:44:18 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190115/49c64075/attachment.html>


More information about the asterisk-code-review mailing list