[Asterisk-code-review] main/cdr: Fixed cdr start overwriting (asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/10747 )

Change subject: main/cdr: Fixed cdr start overwriting
......................................................................


Patch Set 5:

Hi Kevin,

Yes, I thought like that. But I wasn't clear what it supposed to be.
Actually, ARI and AGI's continue action does not create new channel. So it suppose to be not create new cdr for this. That's what I understood.

But since the AGI create new CDR for a long time, may the ARI should follow the convention like the AGI. And need to add the description about this at CDR-specification.

I just need direction where it should go. If @joshua and you agreed with this, I'll fix the code again. :)


-- 
To view, visit https://gerrit.asterisk.org/10747
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I921bc04064b6cff1deb2eea56a94d86489561cdc
Gerrit-Change-Number: 10747
Gerrit-PatchSet: 5
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Sat, 12 Jan 2019 10:31:42 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190112/367168ec/attachment.html>