[Asterisk-code-review] RAII: Change order or variables in clang version (asterisk[master])

[Diederik de Groot]

Diederik de Groot has posted comments on this change. ( https://gerrit.asterisk.org/10854 )

Change subject: RAII: Change order or variables in clang version
......................................................................


Patch Set 3:

Hmmmm... I created the scanbuild script some years ago and presented some of the results (potential null pointer dereferences), but nothing was done with it back then. The problem is that i can put in the time to add support, but if nobody is going to look at the results it will quickly fall into disrepair, i think.

Maybe you (guys) can start by running llvm scanbuild manually for now, have a look at the resulta (maybe add 1-2 annotation to pass atomic functions (during refcount) correctly). There might be a couple of false positives that need rework/annotation and then we can maybe look at entering it into CI if you like what it can do.

Sorry for chatting about this on this (only partially related) issue/review.


-- 
To view, visit https://gerrit.asterisk.org/10854
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00811c34ae910836a5fb6d22304528aef92624db
Gerrit-Change-Number: 10854
Gerrit-PatchSet: 3
Gerrit-Owner: Diederik de Groot <dkgroot at talon.nl>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Diederik de Groot <dkgroot at talon.nl>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Comment-Date: Fri, 11 Jan 2019 17:08:11 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190111/0934c11a/attachment.html>