[Asterisk-code-review] res http websocket: respond to CLOSE opcode (asterisk[16])

[Joshua C. Colp]

Joshua C. Colp has posted comments on this change. ( https://gerrit.asterisk.org/10861 )

Change subject: res_http_websocket: respond to CLOSE opcode
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

Minor documentation tweak comment.

https://gerrit.asterisk.org/#/c/10861/2//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/10861/2//COMMIT_MSG@15
PS2, Line 15: Handling of the CLOSE opcode is moved up with the rest of the opcodes so
            : that unmasking gets applied. The payload is no longer returned to the
            : caller, but neither ARI nor the chan_sip nor pjsip made use of the
            : payload, which is a good thing since it was masked.
The documentation in http_websocket.h should be updated to reflect this change.



-- 
To view, visit https://gerrit.asterisk.org/10861
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: Icb1b60205fc77ee970ddc91d1f545671781344cf
Gerrit-Change-Number: 10861
Gerrit-PatchSet: 2
Gerrit-Owner: Jeremy Lainé <jeremy.laine at m4x.org>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Jeremy Lainé <jeremy.laine at m4x.org>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Fri, 11 Jan 2019 14:12:20 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190111/e4dfac02/attachment.html>