[Asterisk-code-review] res pjsip: add option to enable ContactStatus event when con... (asterisk[16])

[Joshua C. Colp]

Joshua C. Colp has posted comments on this change. ( https://gerrit.asterisk.org/10822 )

Change subject: res_pjsip: add option to enable ContactStatus event when contact is updated
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/10822/2/res/res_pjsip/pjsip_options.c
File res/res_pjsip/pjsip_options.c:

https://gerrit.asterisk.org/#/c/10822/2/res/res_pjsip/pjsip_options.c@2245
PS2, Line 2245: 			ao2_cleanup(aor_options);
It's not possible for aor_options to be NULL here so ao2_ref should be used


https://gerrit.asterisk.org/#/c/10822/2/res/res_pjsip/pjsip_options.c@2250
PS2, Line 2250: 		task_data->aor_options = aor_options;
Document that the ownership of this passes to the structure.



-- 
To view, visit https://gerrit.asterisk.org/10822
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: I706adf7584e7077eb6bde6d9799ca408bc82ce46
Gerrit-Change-Number: 10822
Gerrit-PatchSet: 2
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 08 Jan 2019 11:22:23 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190108/5b3c866e/attachment-0001.html>