[Asterisk-code-review] RTP: reset DTMF last seqno/timestamp on RTP renegotiation (asterisk[13])

[Alexei Gradinari]

Alexei Gradinari has posted comments on this change. ( https://gerrit.asterisk.org/10829 )

Change subject: RTP: reset DTMF last seqno/timestamp on RTP renegotiation
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/10829/1/res/res_rtp_asterisk.c
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/10829/1/res/res_rtp_asterisk.c@6044
PS1, Line 6044: 
> It is possible for this function to be called even if the remote address has not changed. […]
Yes.
The SDP negotiation happens that does not alter the remote address, but the stream still changes so it has to be reset.
In my case it happens on re-INVITE which is triggered by connected line update.



-- 
To view, visit https://gerrit.asterisk.org/10829
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic72b4497e74d801b27a635559c1cf29c16c95254
Gerrit-Change-Number: 10829
Gerrit-PatchSet: 1
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 03 Jan 2019 15:42:12 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190103/ca6ed75b/attachment-0001.html>