[Asterisk-code-review] app queue: Fix crash when using 'b' option on non-ringall qu... (asterisk[16])

[Joshua C. Colp]

Joshua C. Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/10843 )

Change subject: app_queue: Fix crash when using 'b' option on non-ringall queue.
......................................................................

app_queue: Fix crash when using 'b' option on non-ringall queue.

When using the 'b' option to Queue with a queue that was not configured
for ring all a crash would occur as the wrong pointer would be used.

ASTERISK-28218

Change-Id: If1390f64e321047dff24fd2410c95dde74904980
---
M apps/app_queue.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Benjamin Keith Ford: Looks good to me, but someone else must approve
  Sean Bright: Looks good to me, approved
  Joshua C. Colp: Approved for Submit



diff --git a/apps/app_queue.c b/apps/app_queue.c
index 450a4db..92c49b5 100644
--- a/apps/app_queue.c
+++ b/apps/app_queue.c
@@ -4667,7 +4667,7 @@
 			/* Ring just the best channel */
 			ast_debug(1, "Trying '%s' with metric %d\n", best->interface, best->metric);
 			ret = ring_entry(qe, best, busies);
-			if (qe->predial_callee && cur->chan) {
+			if (qe->predial_callee && best->chan) {
 				ast_autoservice_start(best->chan);
 			}
 		}

-- 
To view, visit https://gerrit.asterisk.org/10843
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: merged
Gerrit-Change-Id: If1390f64e321047dff24fd2410c95dde74904980
Gerrit-Change-Number: 10843
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190103/5a1f8375/attachment.html>