[Asterisk-code-review] stasic.c: Fix printf format type mismatches with arguments. (asterisk[13])

Richard Mudgett asteriskteam at digium.com
Wed Jan 2 11:10:46 CST 2019


Hello Friendly Automation, George Joseph, Corey Farrell, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/10826

to look at the new patch set (#2).

Change subject: stasic.c: Fix printf format type mismatches with arguments.
......................................................................

stasic.c: Fix printf format type mismatches with arguments.

An int64_t is not likely the same size as a long.

* Changed the int64_t values in the statistics structs to longs so casting
is not necessary when generating the formatted CLI output.  The offending
members did not need to be int64_t anyway as they were only set by an int
type variable which was already truncating bits.

* Reordered the statistics structs to reduce potential padding bytes.

Change-Id: Ic090a070e9dc4ca650ebdb9c01ed50a581289962
---
M main/stasis.c
1 file changed, 16 insertions(+), 16 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/26/10826/2
-- 
To view, visit https://gerrit.asterisk.org/10826
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic090a070e9dc4ca650ebdb9c01ed50a581289962
Gerrit-Change-Number: 10826
Gerrit-PatchSet: 2
Gerrit-Owner: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190102/da5d4999/attachment.html>


More information about the asterisk-code-review mailing list