[Asterisk-code-review] stasis.c: Added topic_all container (...asterisk[16])

sungtae kim asteriskteam at digium.com
Thu Feb 28 18:53:26 CST 2019


sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11013 )

Change subject: stasis.c: Added topic_all container
......................................................................


Patch Set 5:

I agree. I designed this changes to make the topic's name to unique and tried to give more flexible point.

I wanted to make the user can be possible to subscribing the topic with name. To doing that, the name has to be unique.

But yes, you're right. It's not an easy to digging all the places to checking the duplicated topic's name now. :P

I've just added uniqueid for the topic's key.

Btw, it was a pretty good experience to digging the previous test error. :D


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11013
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ie86d125d2966f93de74ee00f47ae6fbc8c081c5f
Gerrit-Change-Number: 11013
Gerrit-PatchSet: 5
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Fri, 01 Mar 2019 00:53:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190228/9b6e3e69/attachment.html>


More information about the asterisk-code-review mailing list