[Asterisk-code-review] res_pjsip_sdp_rtp: Fix return code from apply_negotiated_sdp_stream (...asterisk[16])

George Joseph asteriskteam at digium.com
Thu Feb 28 11:33:47 CST 2019


George Joseph has uploaded a new patch set (#2) to the change originally created by Friendly Automation. ( https://gerrit.asterisk.org/c/asterisk/+/11070 )

Change subject: res_pjsip_sdp_rtp:  Fix return code from apply_negotiated_sdp_stream
......................................................................

res_pjsip_sdp_rtp:  Fix return code from apply_negotiated_sdp_stream

apply_negotiated_sdp_stream was returning a "1" when no joint
capabilities were found on an outgoing call instead of a "-1".
This indicated to res_pjsip_session that the handler DID handle
the sdp when in fact it didn't.  Without the appropriate setup,
a subsequent media frame coming in would have an invalid stream_num
and cause a seg fault when the stream was attempted to be retrieved.

apply_negotiated_sdp_stream now returns the correct "-1" and any
media is now discarded before it reaches the core stream processing.

ASTERISK-28260
Reported by: Sotiris Ganouris

Change-Id: Ia095cb16b4862f2f6ad6d2d2a77453fa2542371f
---
M res/res_pjsip_sdp_rtp.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/70/11070/2
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11070
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ia095cb16b4862f2f6ad6d2d2a77453fa2542371f
Gerrit-Change-Number: 11070
Gerrit-PatchSet: 2
Gerrit-Owner: Friendly Automation
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190228/1ad065a8/attachment.html>


More information about the asterisk-code-review mailing list