[Asterisk-code-review] app_queue: fixed ordering of events for queue agent dial (...asterisk[16])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11058 )

Change subject: app_queue: fixed ordering of events for queue agent dial
......................................................................


Patch Set 1: Code-Review-1

I feel that this patch will introduce a lot of subtle unintended changes and other bugs.

* The channel snapshots before this change were taken AFTER the channel was called.  So they would indicate that the target was called.

* If the ast_call() fails now you have to report DialEnd when you didn't before because it is defined that you get a DialEnd paired with a DialBegin.

* The ordering of the events for any other calling method does not enforce this ordering change as you are only doing it for app_queue.  Thus the other methods will still send the UserEvent you mention in the ASTERISK issue before the DialBegin events.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11058
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Id0865fb306136f30a1aa8be82f3753c47059ff2d
Gerrit-Change-Number: 11058
Gerrit-PatchSet: 1
Gerrit-Owner: Nathan Bruning <nathan at iperity.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Thu, 28 Feb 2019 00:48:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190227/09597eaa/attachment.html>