[Asterisk-code-review] stasis.c: Added topic_all container (...asterisk[16])

sungtae kim asteriskteam at digium.com
Wed Feb 27 01:37:14 CST 2019


sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11013 )

Change subject: stasis.c: Added topic_all container
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> I believe I've identified the cause of this. You are imposing a new requirement which did not exist before - that topic names have to be unique. This has not been the case before, and there is overlap of topic names. This causes topics to not get created like before, resulting in messages not getting sent. I expect this also impacts master - but to a lesser extent because we removed some usage of the stasis cache there and changed how things work some.

Hi Joshua,

Wow, thank you for your reviewing and diagnosing. :)

If the new topic creating function introduced this bug, what I suppose to do?


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11013
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ie86d125d2966f93de74ee00f47ae6fbc8c081c5f
Gerrit-Change-Number: 11013
Gerrit-PatchSet: 1
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Wed, 27 Feb 2019 07:37:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190227/cd2c58aa/attachment-0001.html>


More information about the asterisk-code-review mailing list