[Asterisk-code-review] Core: Increase AST PBX MAX STACK to 512 if not LOW MEMORY (asterisk[master])

Joshua C. Colp asteriskteam at digium.com
Tue Feb 26 06:08:46 CST 2019


Joshua C. Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/11022 )

Change subject: Core:  Increase AST_PBX_MAX_STACK to 512 if not LOW_MEMORY
......................................................................

Core:  Increase AST_PBX_MAX_STACK to 512 if not LOW_MEMORY

The current settings AST_PBX_MAX_STACK is 128 entries which is
too low for some FreePBX installations with complex parking
arrangements.  Increased to 512 if LOW_MEMORY is not defined.

ASTERISK-28300

Change-Id: I7c4b540bc92e6642df0f3da639b003f7da8b1299
---
M include/asterisk/extconf.h
M include/asterisk/pbx.h
2 files changed, 9 insertions(+), 0 deletions(-)

Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  Joshua C. Colp: Looks good to me, approved; Approved for Submit



diff --git a/include/asterisk/extconf.h b/include/asterisk/extconf.h
index 1a04b01..043d245 100644
--- a/include/asterisk/extconf.h
+++ b/include/asterisk/extconf.h
@@ -220,7 +220,11 @@
 	E_SPAWN =	0x12,	/* want to spawn an extension. Requires exact match */
 	E_FINDLABEL =	0x22	/* returns the priority for a given label. Requires exact match */
 };
+#ifdef LOW_MEMORY
 #define AST_PBX_MAX_STACK  128
+#else
+#define AST_PBX_MAX_STACK  512
+#endif
 
 /* request and result for pbx_find_extension */
 struct pbx_find_info {
diff --git a/include/asterisk/pbx.h b/include/asterisk/pbx.h
index a40c6a4..cbc5ec2 100644
--- a/include/asterisk/pbx.h
+++ b/include/asterisk/pbx.h
@@ -1602,7 +1602,12 @@
 #define STATUS_NO_PRIORITY	3
 #define STATUS_NO_LABEL		4
 #define STATUS_SUCCESS		5
+
+#ifdef LOW_MEMORY
 #define AST_PBX_MAX_STACK  128
+#else
+#define AST_PBX_MAX_STACK  512
+#endif
 
 /* request and result for pbx_find_extension */
 struct pbx_find_info {

-- 
To view, visit https://gerrit.asterisk.org/11022
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c4b540bc92e6642df0f3da639b003f7da8b1299
Gerrit-Change-Number: 11022
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190226/d2fdc075/attachment.html>


More information about the asterisk-code-review mailing list