[Asterisk-code-review] audio analyzer: Don't wrap tones in " (testsuite[16])

Friendly Automation asteriskteam at digium.com
Thu Feb 21 13:11:41 CST 2019


Friendly Automation has submitted this change and it was merged. ( https://gerrit.asterisk.org/11028 )

Change subject: audio_analyzer: Don't wrap tones in "
......................................................................

audio_analyzer: Don't wrap tones in "

The tone URI scheme does not require wrapping
the tones in ". Doing so causes a parsing failure
in Asterisk, resulting in failure.

Change-Id: Ic4bce9285e2e437ad0ae752aaf4be5220b7e3f50
---
M tests/codecs/audio_analyzer.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Kevin Harwell: Looks good to me, but someone else must approve
  George Joseph: Looks good to me, approved
  Friendly Automation: Approved for Submit



diff --git a/tests/codecs/audio_analyzer.py b/tests/codecs/audio_analyzer.py
index e656777..c897c45 100644
--- a/tests/codecs/audio_analyzer.py
+++ b/tests/codecs/audio_analyzer.py
@@ -41,7 +41,7 @@
         for t in test_object.tones:
             tones += str(t['frequency']) + '/' + str(t['duration']) + ','
             duration += t['duration']
-        return ('tone:\"' + tones.rstrip(',') + '\"', duration / 1000)
+        return ('tone:' + tones.rstrip(','), duration / 1000)
 
     return __get_playback_file() if test_object.playback_file else __get_tones()
 

-- 
To view, visit https://gerrit.asterisk.org/11028
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4bce9285e2e437ad0ae752aaf4be5220b7e3f50
Gerrit-Change-Number: 11028
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190221/71cb1c93/attachment.html>


More information about the asterisk-code-review mailing list