[Asterisk-code-review] res mwi devstate.c: New module to allow presense subs to VM ... (asterisk[13])

[Joshua C. Colp]

Joshua C. Colp has posted comments on this change. ( https://gerrit.asterisk.org/11023 )

Change subject: res_mwi_devstate.c: New module to allow presense subs to VM boxes
......................................................................


Patch Set 1: Code-Review-1

(7 comments)

This should also have an entry in the CHANGES file

https://gerrit.asterisk.org/#/c/11023/1//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/11023/1//COMMIT_MSG@7
PS1, Line 7: res_mwi_devstate.c: New module to allow presense subs to VM boxes
presence


https://gerrit.asterisk.org/#/c/11023/1//COMMIT_MSG@9
PS1, Line 9: This module allows presense subscriptions to voicemail boxes.  This
presence


https://gerrit.asterisk.org/#/c/11023/1/res/res_mwi_devstate.c
File res/res_mwi_devstate.c:

https://gerrit.asterisk.org/#/c/11023/1/res/res_mwi_devstate.c@38
PS1, Line 38: 	if (!stasis_subscription_is_subscribed(sub) || ast_mwi_state_type() != stasis_message_type(msg)) {
It shouldn't be possible to not be subscribed when this is called


https://gerrit.asterisk.org/#/c/11023/1/res/res_mwi_devstate.c@64
PS1, Line 64: static int unload_module(void) {
unload_module and load_module should match the rest and have { on the next line


https://gerrit.asterisk.org/#/c/11023/1/res/res_mwi_devstate.c@71
PS1, Line 71: 	RAII_VAR(struct ao2_container *, cached, NULL, ao2_cleanup);
No need for RAII_VAR


https://gerrit.asterisk.org/#/c/11023/1/res/res_mwi_devstate.c@76
PS1, Line 76: 
This subscription should have an ast_mwi_state_type message type added as an accepted message type


https://gerrit.asterisk.org/#/c/11023/1/res/res_mwi_devstate.c@84
PS1, Line 84: 		.load = load_module,
This needs the support level added



-- 
To view, visit https://gerrit.asterisk.org/11023
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I62a246c24f3d7d432e33e22d7a4a57c15c292fdd
Gerrit-Change-Number: 11023
Gerrit-PatchSet: 1
Gerrit-Owner: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 12:29:52 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190221/18977f78/attachment.html>