[Asterisk-code-review] stasis.c: Added topic all container (asterisk[16])

Joshua C. Colp asteriskteam at digium.com
Thu Feb 21 05:15:53 CST 2019


Joshua C. Colp has posted comments on this change. ( https://gerrit.asterisk.org/11013 )

Change subject: stasis.c: Added topic_all container
......................................................................


Patch Set 1:

I'm not seeing the same result. If I build Asterisk 16 on two different machines and run the CDR unit tests, they work fine:

24 Test(s) Executed  24 Passed  0 Failed

If I pull this patch in then I get:

24 Test(s) Executed  4 Passed  20 Failed

I also rebased this change on top of the latest 16 just to be sure and it still fails.

If the CDR tests were constantly failing for that long I'd also expect the Jenkins unit tests for uploaded reviews to have been failing too, or others to have reported the problem (I did lots of work in Stasis which impacted CDRs some so ran those tests a lot recently too). Your failure may be something different and environment specific.


-- 
To view, visit https://gerrit.asterisk.org/11013
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie86d125d2966f93de74ee00f47ae6fbc8c081c5f
Gerrit-Change-Number: 11013
Gerrit-PatchSet: 1
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Thu, 21 Feb 2019 11:15:53 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190221/d2b12cec/attachment.html>


More information about the asterisk-code-review mailing list