[Asterisk-code-review] http.c: Support separated HTTP request (asterisk[master])

Joshua C. Colp asteriskteam at digium.com
Wed Feb 20 05:22:02 CST 2019


Joshua C. Colp has posted comments on this change. ( https://gerrit.asterisk.org/10869 )

Change subject: http.c: Support separated HTTP request
......................................................................


Patch Set 8:

> Patch Set 8:
> 
> Should I cherry pick this for Asterisk-13?
> Because, it need ast_iostream_read(), which is not merged into Asterisk-13 yet.
> 
> What this suppose to be? Merge entire of iostream features? or adding only particular part?

It should be applied to the applicable branches. If the problem doesn't exist in 13, then it doesn't need to be there. If it does exist there but using different underlying API then it should also be resolved there - by providing a fix specific to 13.

The iostream API isn't going to be backported.


-- 
To view, visit https://gerrit.asterisk.org/10869
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48a401aa64a21c3b37bf3cb4e0486d64b7dd8aa1
Gerrit-Change-Number: 10869
Gerrit-PatchSet: 8
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Michael L. Young <elgueromexicano at gmail.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Wed, 20 Feb 2019 11:22:02 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190220/18617b52/attachment.html>


More information about the asterisk-code-review mailing list