[Asterisk-code-review] res/res rtp asterisk: clear smoother when local bridging (asterisk[13])
Joshua C. Colp
asteriskteam at digium.com
Wed Feb 20 04:46:21 CST 2019
Joshua C. Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/10989 )
Change subject: res/res_rtp_asterisk: clear smoother when local bridging
......................................................................
res/res_rtp_asterisk: clear smoother when local bridging
p2p_write updates txformat but doesn't require a smoother. If a smoother
was created by another bridge type the smoother could fall out of date causing
one way audio issues. To prevent this the smoother is now destroyed on the
start of native bridge.
ASTERISK-28284 #close
Change-Id: I84e67f144963787fff9b4d79ac500514fb40cdc6
---
M res/res_rtp_asterisk.c
1 file changed, 4 insertions(+), 0 deletions(-)
Approvals:
Joshua C. Colp: Looks good to me, but someone else must approve; Approved for Submit
George Joseph: Looks good to me, but someone else must approve
Sean Bright: Looks good to me, but someone else must approve
Kevin Harwell: Looks good to me, approved
diff --git a/res/res_rtp_asterisk.c b/res/res_rtp_asterisk.c
index 77eba21..8fc52a0 100644
--- a/res/res_rtp_asterisk.c
+++ b/res/res_rtp_asterisk.c
@@ -6153,6 +6153,10 @@
ao2_lock(instance0);
ast_set_flag(rtp, FLAG_NEED_MARKER_BIT | FLAG_REQ_LOCAL_BRIDGE_BIT);
+ if (rtp->smoother) {
+ ast_smoother_free(rtp->smoother);
+ rtp->smoother = NULL;
+ }
ao2_unlock(instance0);
return 0;
--
To view, visit https://gerrit.asterisk.org/10989
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings
Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: merged
Gerrit-Change-Id: I84e67f144963787fff9b4d79ac500514fb40cdc6
Gerrit-Change-Number: 10989
Gerrit-PatchSet: 4
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190220/74cfdd55/attachment.html>
More information about the asterisk-code-review
mailing list