[Asterisk-code-review] Added creation timestamp for the bridge (asterisk[master])

sungtae kim asteriskteam at digium.com
Tue Feb 19 15:57:06 CST 2019


sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/10986 )

Change subject: Added creation timestamp for the bridge
......................................................................


Patch Set 3:

(3 comments)

Hi Joshua, 

Thank you for your kind reviewing. Yes, I've fixed what you mentioned things. :)

https://gerrit.asterisk.org/#/c/10986/1//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/10986/1//COMMIT_MSG@9
PS1, Line 9: This small feature will help to checking the bridge's status to
> You don't need to copy the first line here
Sure, fixed it!


https://gerrit.asterisk.org/#/c/10986/1//COMMIT_MSG@14
PS1, Line 14: ASTERISK-28279
> This needs the ASTERISK issue
Sure, added it. :)


https://gerrit.asterisk.org/#/c/10986/1/rest-api/api-docs/bridges.json
File rest-api/api-docs/bridges.json:

https://gerrit.asterisk.org/#/c/10986/1/rest-api/api-docs/bridges.json@757
PS1, Line 757: 				"creationtime": {
             : 					"required": true,
             : 					"type": "Date",
             : 					"description": "Timestamp when bridge was created"
             : 				}
> This indentation doesn't match the rest of the JSON
Oops, yes. I've fixed it! :)



-- 
To view, visit https://gerrit.asterisk.org/10986
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I460238c488eca4d216b9176576211cb03286e040
Gerrit-Change-Number: 10986
Gerrit-PatchSet: 3
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Tue, 19 Feb 2019 21:57:06 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190219/97aee40a/attachment.html>


More information about the asterisk-code-review mailing list