[Asterisk-code-review] chan pjsip: Changed to continued after invalid media for pjs... (asterisk[16])

sungtae kim asteriskteam at digium.com
Tue Feb 19 15:41:07 CST 2019


sungtae kim has uploaded this change for review. ( https://gerrit.asterisk.org/11011


Change subject: chan_pjsip: Changed to continued after invalid media for pjsip show channelstats
......................................................................

chan_pjsip: Changed to continued after invalid media for pjsip show channelstats

Currently, the pjsip show channelstats cli does not show channel's
stats after hits the invalid channel info. This makes hard to use
this cli. Changed to keep iterate after hits the invalid channel
info.

ASTERISK-28292

Change-Id: I3efdff1c9e1b1efd3c971fb82ae77aa133a6f43c
---
M channels/pjsip/cli_commands.c
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/11/11011/1

diff --git a/channels/pjsip/cli_commands.c b/channels/pjsip/cli_commands.c
index 33d0e02..7e932da 100644
--- a/channels/pjsip/cli_commands.c
+++ b/channels/pjsip/cli_commands.c
@@ -354,7 +354,7 @@
 
 	if (!channel) {
 		ast_str_append(&context->output_buffer, 0, " %s not valid\n", snapshot->name);
-		return -1;
+		return 0;
 	}
 
 	ast_channel_lock(channel);
@@ -364,7 +364,7 @@
 		ast_str_append(&context->output_buffer, 0, " %s not valid\n", snapshot->name);
 		ast_channel_unlock(channel);
 		ao2_cleanup(channel);
-		return -1;
+		return 0;
 	}
 
 	media = session->active_media_state->default_session[AST_MEDIA_TYPE_AUDIO];
@@ -372,7 +372,7 @@
 		ast_str_append(&context->output_buffer, 0, " %s not valid\n", snapshot->name);
 		ast_channel_unlock(channel);
 		ao2_cleanup(channel);
-		return -1;
+		return 0;
 	}
 
 	rtp = ao2_bump(media->rtp);

-- 
To view, visit https://gerrit.asterisk.org/11011
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3efdff1c9e1b1efd3c971fb82ae77aa133a6f43c
Gerrit-Change-Number: 11011
Gerrit-PatchSet: 1
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190219/961b6a58/attachment.html>


More information about the asterisk-code-review mailing list