[Asterisk-code-review] force inline: remove all force inline from asterisk. (asterisk[master])

[Chris Savinovich]

Chris Savinovich has posted comments on this change. ( https://gerrit.asterisk.org/10936 )

Change subject: force_inline: remove all force_inline from asterisk.
......................................................................


Patch Set 4:

> 
 > My concern is that this patch is completely disabling inlining for
 > some tiny functions.
 > 
 > Someone had asked why we couldn't just remove the `force_inline`
 > but leave these in the headers, it was pointed out that GCC would
 > complain about the functions being unused.  Couldn't we just
 > replace `force_inline` with `attribute_unused`?  This way GCC won't
 > complain about the unused static functions and we'd still allow it
 > to be inlined if GCC wants.

Hi Corey, maybe there is a bit of a confusion, there is one comment back there I entered wrong and couldn't delete and tried to rephrased it in the subsequent comment. In any case here is to clarfy: This patch does not use flag -fno-partial-inline. It was discussed that since this is a master version it will be okay to move the funcions out of the header file since master versions don't mind about ABI breakages. Therefore it will be okay with removing the force_inline from the prototypes in include/asterisk/strings.h.  Not sure if that was your concern.
Thanks


-- 
To view, visit https://gerrit.asterisk.org/10936
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a90249763a7139fd12c54ad4e0e8d5cbbed14f9
Gerrit-Change-Number: 10936
Gerrit-PatchSet: 4
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Comment-Date: Mon, 18 Feb 2019 18:14:49 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190218/24c5d1f9/attachment.html>