[Asterisk-code-review] Added creation timestamp for the bridge (asterisk[master])

Joshua C. Colp asteriskteam at digium.com
Mon Feb 18 08:47:25 CST 2019


Joshua C. Colp has posted comments on this change. ( https://gerrit.asterisk.org/10986 )

Change subject: Added creation timestamp for the bridge
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/10986/1//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/10986/1//COMMIT_MSG@9
PS1, Line 9: Added creation timestamp for the bridge. This small feature will
You don't need to copy the first line here


https://gerrit.asterisk.org/#/c/10986/1//COMMIT_MSG@14
PS1, Line 14: 
This needs the ASTERISK issue


https://gerrit.asterisk.org/#/c/10986/1/rest-api/api-docs/bridges.json
File rest-api/api-docs/bridges.json:

https://gerrit.asterisk.org/#/c/10986/1/rest-api/api-docs/bridges.json@757
PS1, Line 757:         "creationtime": {
             :           "required": true,
             :           "type": "Date",
             :           "description": "Timestamp when bridge was created"
             :         },
This indentation doesn't match the rest of the JSON



-- 
To view, visit https://gerrit.asterisk.org/10986
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I460238c488eca4d216b9176576211cb03286e040
Gerrit-Change-Number: 10986
Gerrit-PatchSet: 1
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 18 Feb 2019 14:47:25 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190218/b3222a79/attachment.html>


More information about the asterisk-code-review mailing list