[Asterisk-code-review] ARI event type filtering (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/10978 )

Change subject: ARI event type filtering
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Just nits.

https://gerrit.asterisk.org/#/c/10978/2/include/asterisk/stasis_app.h
File include/asterisk/stasis_app.h:

https://gerrit.asterisk.org/#/c/10978/2/include/asterisk/stasis_app.h@152
PS2, Line 152:  *
\since?


https://gerrit.asterisk.org/#/c/10978/2/res/stasis/app.c
File res/stasis/app.c:

https://gerrit.asterisk.org/#/c/10978/2/res/stasis/app.c@71
PS2, Line 71: 	struct ast_json *allowed;
            : 	/*! An array of disallowed events types for this application */
            : 	struct ast_json *disallowed;
How about renaming to events_allowed and events_disallowed?



-- 
To view, visit https://gerrit.asterisk.org/10978
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I9671ba1fcdb3b6c830b553d4c5365aed5d588d5b
Gerrit-Change-Number: 10978
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 15 Feb 2019 15:08:45 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190215/e7f7a0e9/attachment.html>