[Asterisk-code-review] force inline: remove all force inline from asterisk. (asterisk[master])

Walter Doekes asteriskteam at digium.com
Wed Feb 13 09:28:33 CST 2019


Walter Doekes has posted comments on this change. ( https://gerrit.asterisk.org/10936 )

Change subject: force_inline: remove all force_inline from asterisk.
......................................................................


Patch Set 4:

(1 comment)

I recall that fixing braces was mandatory when touching code.

https://gerrit.asterisk.org/#/c/10936/4/main/audiohook.c
File main/audiohook.c:

https://gerrit.asterisk.org/#/c/10936/4/main/audiohook.c@1441
PS4, Line 1441: 		*input = (short) res;
Coding style braces while touching these?

if (res > 32767) {
    ...
} else ...



-- 
To view, visit https://gerrit.asterisk.org/10936
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a90249763a7139fd12c54ad4e0e8d5cbbed14f9
Gerrit-Change-Number: 10936
Gerrit-PatchSet: 4
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Comment-Date: Wed, 13 Feb 2019 15:28:33 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190213/4e748e59/attachment.html>


More information about the asterisk-code-review mailing list