[Asterisk-code-review] sched: Don't allow ast sched del to deadlock ast sched runq ... (asterisk[13])

Walter Doekes asteriskteam at digium.com
Tue Feb 12 10:57:11 CST 2019


Walter Doekes has posted comments on this change. ( https://gerrit.asterisk.org/10991 )

Change subject: sched: Don't allow ast_sched_del to deadlock ast_sched_runq from same thread
......................................................................


Patch Set 1:

I plan to rebase upwards (16/master) as necessary after this is approved.

More info on the issue can be found in the ticket, including a patch to aid in reproducing (ASTERISK-28282_reproducing_sched_unref_self_deadlock.patch).

If possible, I'd also like to submit:

- ASTERISK-28282_improving_sip_show_sched.patch (more output in 'sip show sched')

- ASTERISK-28282_suggest_locking_less_in_mixmonitor_b.patch (locking less in "MixMonitor,b" which I think aggravated the load, causing the bug to appear more often)

- ASTERISK-28282_no_sip_poke_peer_now_if_no_qualify.patch (don't even schedule the callback if we're just going to clear it immediately)


-- 
To view, visit https://gerrit.asterisk.org/10991
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic26777fa0732725e6ca7010df17af77a012aa856
Gerrit-Change-Number: 10991
Gerrit-PatchSet: 1
Gerrit-Owner: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Walter Doekes <walter+asterisk at wjd.nu>
Gerrit-Comment-Date: Tue, 12 Feb 2019 16:57:11 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190212/2da36d8c/attachment.html>


More information about the asterisk-code-review mailing list