[Asterisk-code-review] Fixed wrong RTCPReceived, RTCPSent description (asterisk[master])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/10988 )

Change subject: Fixed wrong RTCPReceived, RTCPSent description
......................................................................


Patch Set 1: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/10988/1/main/rtp_engine.c
File main/rtp_engine.c:

https://gerrit.asterisk.org/#/c/10988/1/main/rtp_engine.c@92
PS1, Line 92: 					interarrival time, measured in milliseconds.</para>
I don't see any indication from RFC 3550 that this will always be milliseconds.


https://gerrit.asterisk.org/#/c/10988/1/main/rtp_engine.c@100
PS1, Line 100: 					<para>The delay, expressed in units of 1/65536 seconds(each unit is ~0.000015 seconds)
I don't think this clarification is necessary. The 'X/Y something' notation is well understood.


https://gerrit.asterisk.org/#/c/10988/1/main/rtp_engine.c@123
PS1, Line 123: 					<para>Calculated Round-Trip Time in milliseconds</para>
Have you confirmed that this is milliseconds and not seconds (or 'timestamp units' for that matter)?



-- 
To view, visit https://gerrit.asterisk.org/10988
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f306e8214ea86a606c7d5537acdc62b0db14e51
Gerrit-Change-Number: 10988
Gerrit-PatchSet: 1
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Tue, 12 Feb 2019 15:46:30 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190212/d9495f12/attachment.html>