[Asterisk-code-review] bridge.c: enabled bridge destroy cli as a default (asterisk[master])

sungtae kim asteriskteam at digium.com
Sat Feb 9 05:40:51 CST 2019


sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/10987 )

Change subject: bridge.c: enabled bridge destroy cli as a default
......................................................................


Patch Set 2:

> This command is only available to developers for a reason. Only the
 > owner of the bridge is meant to destroy it. Calling it outside of
 > the owner can leave it in an undefined state, and depending on the
 > implementation of the owner it can result in a crash or weird
 > behavior. The "bridge kick" command has an "all" option
 > specifically for this reason, as that is a defined mechanism for
 > owners of bridges.
 > 
 > This was changed and done back in Asterisk 12[1] after testing.
 > 
 > [1] https://issues.asterisk.org/jira/browse/ASTERISK-23987

Okay, there was reason for that. Btw, I think, for/as the/a administrator, need some feature/power to destroy the bridge somehow. Because it consuming the resource.

If the bridge owner(may other endpoint of ARI/AMI application) was crashed or with bad managing, it's noway to destroy the bridge. And it will leave it forever.


-- 
To view, visit https://gerrit.asterisk.org/10987
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I99ff7b308236781003663bb32f2f2f3461cff209
Gerrit-Change-Number: 10987
Gerrit-PatchSet: 2
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Sat, 09 Feb 2019 11:40:51 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190209/5d1f305c/attachment.html>


More information about the asterisk-code-review mailing list