[Asterisk-code-review] json.c/strings.c - Add a couple of utility functions (asterisk[master])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10981 )

Change subject: json.c/strings.c - Add a couple of utility functions
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/10981/1/main/json.c
File main/json.c:

https://gerrit.asterisk.org/#/c/10981/1/main/json.c@407
PS1, Line 407: 	return ast_json_string_get(ast_json_object_get(object, key));
Why not just put a macro in json.h?

This would avoid creating a new symbol so module which uses this routine would not require Asterisk 13.26.0 / 16.3.0 at runtime, they'd load against 13.0.0 and 16.0.0.



-- 
To view, visit https://gerrit.asterisk.org/10981
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I26f0a16d61537505eb41b4b05ef2e6d67fc2541b
Gerrit-Change-Number: 10981
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Comment-Date: Fri, 08 Feb 2019 21:18:17 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190208/02be48a0/attachment.html>