[Asterisk-code-review] app amd: Infinite loop on silent calls (asterisk[16])

Tue Feb 5 05:46:17 CST 2019

Since it was a server with load was not able to do a RTP trace . Instead of NULL frame did the following now 

if (res > 0) {
            ms = 2 * maxWaitTimeForFrame - res;
        } else {
            ms = 2 * maxWaitTimeForFrame;
        }

else {
            ast_verb(3, "AMD: The frame [%s] is neither VOICE nor CNG so what is it and what do we do for this\n",ast_channel_name(chan));
            iTotalTime += ms;
            if (iTotalTime >= totalAnalysisTime) {
                ast_verb(3, "AMD: Channel [%s]. Too long...\n", ast_channel_name(chan));
                ast_frfree(f);
                strcpy(amdStatus , "NOTSURE");
                sprintf(amdCause , "TOOLONG-%d", iTotalTime);
                break;
            }
        }

With the above calculation was able to get out from AMD after the totalAnalysis time .

Regards,

> On 05-Feb-2019, at 4:47 PM, Joshua C. Colp <jcolp at digium.com> wrote:
> 
> Did you get an RTP trace to see what the actual packets were that were coming in or the SDP as well?
> 
> From a PJSIP and RTP perspective there are a few cases where it would return NULL frames, but they are in off-nominal cases where things would not work right. That may be it.
> 
> On Tue, Feb 5, 2019, at 7:08 AM, Abhay Gupta wrote:
>> [Feb 5 16:26:15] VERBOSE[25500][C-0000009e] pbx.c: Executing 
>> [dialer at 2:2] AMD("PJSIP/ICONMAIN-000000d1", "") in new stack
>> [Feb 5 16:29:22] VERBOSE[25500][C-0000009e] app_amd.c: AMD: The frame 
>> [PJSIP/ICONMAIN-000000d1] is neither VOICE nor CNG so what is it and 
>> what do we do for this
>> [Feb 5 16:29:22] VERBOSE[25500][C-0000009e] app_amd.c: AMD: Channel 
>> [PJSIP/ICONMAIN-000000d1]. HANGUP
>> 
>> See the above call went into AMD at 16:26:15 and for 3 min was in AMD 
>> till a HANGUP message came . And in between the frame was not VOICE or 
>> CNG so what it was and why it continued to be in AMD is something I 
>> have not understood .
>> 
>> 
>> Regards,
>> 
>> Abhay Gupta
>> 
>> 
>> 
>> 
>>> On 05-Feb-2019, at 4:16 PM, Abhay Gupta <abhay at avissol.com> wrote:
>>> 
>>> Hi , 
>>> 
>>> I have been able to capture logs . I will also send the log if I see the call getting held up in AMD app .
>>> 
>>> *-- *AMD: We got res as 0 on [PJSIP/ICONMAIN-0000000a] and so no time is extended
>>> * -- *AMD: The frame [PJSIP/ICONMAIN-0000000a] is neither VOICE nor CNG so what is it and what do we do for this
>>> * -- *AMD: We got res as 0 on [PJSIP/ICONMAIN-0000000a] and so no time is extended
>>> * -- *AMD: The frame [PJSIP/ICONMAIN-0000000a] is neither VOICE nor CNG so what is it and what do we do for this
>>> * -- *AMD: We got res as 0 on [PJSIP/ICONMAIN-0000000a] and so no time is extended
>>> * -- *AMD: The frame [PJSIP/ICONMAIN-0000000a] is neither VOICE nor CNG so what is it and what do we do for this
>>> * -- *AMD: We got res as 0 on [PJSIP/ICONMAIN-0000000a] and so no time is extended
>>> * -- *AMD: The frame [PJSIP/ICONMAIN-0000000a] is neither VOICE nor CNG so what is it and what do we do for this
>>> * -- *AMD: We got res as 0 on [PJSIP/ICONMAIN-0000000a] and so no time is extended
>>> * -- *AMD: The frame [PJSIP/ICONMAIN-0000000a] is neither VOICE nor CNG so what is it and what do we do for this
>>> [Feb 5 16:11:17] *WARNING*[9719]: *res_pjsip_outbound_registration.c*:*796* *schedule_retry*: No response received from 'sip:ZestBpo at 103.47.165.10:5061' on registration attempt to 'sip:ZestBpo at 103.47.165.10:5061', retrying in '60'
>>> * -- *AMD: We got res as 0 on [PJSIP/ICONMAIN-0000000a] and so no time is extended
>>> * -- *AMD: The frame [PJSIP/ICONMAIN-0000000a] is neither VOICE nor CNG so what is it and what do we do for this
>>> * -- *AMD: We got res as 0 on [PJSIP/ICONMAIN-0000000a] and so no time is extended
>>> * -- *AMD: The frame [PJSIP/ICONMAIN-0000000a] is neither VOICE nor CNG so what is it and what do we do for this
>>> * -- *AMD: We got res as 0 on [PJSIP/ICONMAIN-0000000a] and so no time is extended
>>> * -- *AMD: The frame [PJSIP/ICONMAIN-0000000a] is neither VOICE nor CNG so what is it and what do we do for this
>>> * -- *AMD: We got res as 0 on [PJSIP/ICONMAIN-0000000a] and so no time is extended
>>> * -- *AMD: The frame [PJSIP/ICONMAIN-0000000a] is neither VOICE nor CNG so what is it and what do we do for this
>>> * -- *AMD: We got res as 0 on [PJSIP/ICONMAIN-0000000a] and so no time is extended
>>> * -- *AMD: The frame [PJSIP/ICONMAIN-0000000a] is neither VOICE nor CNG so what is it and what do we do for this
>>> * -- *<PJSIP/ICONMAIN-00000005>AGI Script agi://127.0.0.1/AGI?AMDCall completed, returning 0
>>> 
>>> The change for Log is in the attached modified file .
>>> <app_amd.c>
>>> 
>>> Regards,
>>> 
>>> Abhay Gupta
>>> 
>>> 
>>> 
>>> 
>>>> On 29-Jan-2019, at 9:51 PM, Matthew Fredrickson <asteriskteam at digium.com> wrote:
>>>> 
>>>> Abhay, do you think you can try to do that?
>> 
>>>> View Change <https://gerrit.asterisk.org/10736 <https://gerrit.asterisk.org/10736>>
>> 
>>>> To view, visit change 10736 <https://gerrit.asterisk.org/10736 <https://gerrit.asterisk.org/10736>>. To unsubscribe, or for help writing mail filters, visit settings <https://gerrit.asterisk.org/settings <https://gerrit.asterisk.org/settings>>.
>> 
>>>> 
>>>> Gerrit-Project: asterisk 
>>>> 
>>>> Gerrit-Branch: 16 
>>>> 
>>>> Gerrit-MessageType: comment 
>>>> 
>>>> Gerrit-Change-Id: I24726bd29d7e467fc721ca265363417234b22855 
>>>> 
>>>> Gerrit-Change-Number: 10736 
>>>> 
>>>> Gerrit-PatchSet: 1 
>>>> 
>>>> Gerrit-Owner: Abhay Gupta <abhay at avissol.com> 
>>>> 
>>>> Gerrit-Reviewer: Abhay Gupta <abhay at avissol.com> 
>>>> 
>>>> Gerrit-Reviewer: Friendly Automation (1000185) 
>>>> 
>>>> Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com> 
>>>> 
>>>> Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com> 
>>>> 
>>>> Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com> 
>>>> 
>>>> Gerrit-Comment-Date: Tue, 29 Jan 2019 16:21:58 +0000 
>>>> 
>>>> Gerrit-HasComments: No 
>>>> 
>>>> Gerrit-HasLabels: No 
>>>> 
>>> 
>> 
> 
> -- 
> Joshua C. Colp
> Digium - A Sangoma Company | Senior Software Developer
> 445 Jan Davis Drive NW - Huntsville, AL 35806 - US
> Check us out at: www.digium.com <http://www.digium.com/> & www.asterisk.org <http://www.asterisk.org/>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190205/9bbd0d37/attachment-0001.html>