[Asterisk-code-review] force inline: remove all force inline from asterisk. (asterisk[master])

[Chris Savinovich]

Hello Friendly Automation, George Joseph, Joshua C. Colp, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/10936

to look at the new patch set (#4).

Change subject: force_inline: remove all force_inline from asterisk.
......................................................................

force_inline: remove all force_inline from asterisk.

A bug in GCC causes arithmetic calculations to fail if the
following conditions are met:
1. TEST_FRAMEWORK on
2. DONT_OPTIMIZE off
3. Fedora and Ubuntu
4. GCC 8.2.1
5. There must exist a certain combination of multithreading.
6. Optimization level -O2 and -O3
7. Flag -fpartial-inline activated (happens automatically when -O2)
Forcing inlining in our code is the actual bug trigger.  The new
concensus is that it is best to leave it to the compiler to determine
what to inline.  Therefore this fix removes all instances of custom
type force_inline wherever possible throughout the Asterisk code.

Change-Id: I2a90249763a7139fd12c54ad4e0e8d5cbbed14f9
---
M include/asterisk/sem.h
M include/asterisk/strings.h
M include/asterisk/utils.h
M main/audiohook.c
M main/sem.c
M main/strings.c
M main/utils.c
7 files changed, 182 insertions(+), 153 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/36/10936/4
-- 
To view, visit https://gerrit.asterisk.org/10936
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2a90249763a7139fd12c54ad4e0e8d5cbbed14f9
Gerrit-Change-Number: 10936
Gerrit-PatchSet: 4
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190206/62499a1c/attachment-0001.html>