[Asterisk-code-review] app amd: Infinite loop on silent calls (asterisk[16])

[Matthew Fredrickson]

Matthew Fredrickson has posted comments on this change. ( https://gerrit.asterisk.org/10736 )

Change subject: app_amd: Infinite loop on silent calls
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

https://gerrit.asterisk.org/#/c/10736/1/apps/app_amd.c
File apps/app_amd.c:

https://gerrit.asterisk.org/#/c/10736/1/apps/app_amd.c@298
PS1, Line 298: 		if (f->frametype == AST_FRAME_VOICE || f->frametype == AST_FRAME_CNG || f->frametype == AST_FRAME_NULL) {
> This was not addressed by Josh's previous comment. […]
It doesn't look like it got posted to the issue, but he provided a lot of data that seems to substantiate the scenario he was running into.



-- 
To view, visit https://gerrit.asterisk.org/10736
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: comment
Gerrit-Change-Id: I24726bd29d7e467fc721ca265363417234b22855
Gerrit-Change-Number: 10736
Gerrit-PatchSet: 1
Gerrit-Owner: Abhay Gupta <abhay at avissol.com>
Gerrit-Reviewer: Abhay Gupta <abhay at avissol.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Matthew Fredrickson <creslin at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Wed, 06 Feb 2019 16:39:43 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190206/ed6d599c/attachment.html>