[Asterisk-code-review] build: Revise CHANGES and UPGRADE.txt handling. (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/10943 )

Change subject: build: Revise CHANGES and UPGRADE.txt handling.
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

I'd also recommend making the README files README.md files instead and using markdown to break up sections and examples, etc...

https://gerrit.asterisk.org/#/c/10943/1/doc/CHANGES-staging/README
File doc/CHANGES-staging/README:

https://gerrit.asterisk.org/#/c/10943/1/doc/CHANGES-staging/README@7
PS1, Line 7: The file does not need to have a meaningful name, but
           : it probably should.
Should we enforce a ".txt" extension, so it's easier to open by some?


https://gerrit.asterisk.org/#/c/10943/1/doc/CHANGES-staging/README@9
PS1, Line 9: "SUBJECT:"
Is this case sensitive? Probably should specify if it is or not. Here it is all caps, and in the examples below, but the files have "Subject".


https://gerrit.asterisk.org/#/c/10943/1/doc/UPGRADE-staging/README
File doc/UPGRADE-staging/README:

https://gerrit.asterisk.org/#/c/10943/1/doc/UPGRADE-staging/README@6
PS1, Line 6: The
           : file does not need to have a meaningful name,
Same for this, should we enforce .txt extension?


https://gerrit.asterisk.org/#/c/10943/1/doc/UPGRADE-staging/README@9
PS1, Line 9: SUBJECT:
Case sensitive?



-- 
To view, visit https://gerrit.asterisk.org/10943
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I19cf4b569321c88155a65e9b0b80f6d58075dd47
Gerrit-Change-Number: 10943
Gerrit-PatchSet: 1
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 05 Feb 2019 21:41:49 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190205/b4dcc90c/attachment-0001.html>