[Asterisk-code-review] res stasis: Add ability to switch applications. (asterisk[13])

[Joshua C. Colp]

Joshua C. Colp has posted comments on this change. ( https://gerrit.asterisk.org/10937 )

Change subject: res_stasis: Add ability to switch applications.
......................................................................


Patch Set 5: Code-Review-1

(3 comments)

https://gerrit.asterisk.org/#/c/10937/5//COMMIT_MSG
Commit Message:

https://gerrit.asterisk.org/#/c/10937/5//COMMIT_MSG@15
PS5, Line 15: name is "ApplicationMoveFailed", and provides the "destination" that the
This new event should be documented in the JSON as well.


https://gerrit.asterisk.org/#/c/10937/5/res/res_stasis.c
File res/res_stasis.c:

https://gerrit.asterisk.org/#/c/10937/5/res/res_stasis.c@1401
PS5, Line 1401: 						"destination", control_next_app(control));
Should this include arguments?


https://gerrit.asterisk.org/#/c/10937/5/res/stasis/control.c
File res/stasis/control.c:

https://gerrit.asterisk.org/#/c/10937/5/res/stasis/control.c@146
PS5, Line 146: 		ao2_cleanup(app);
I believe this will double unref app, as it should be unreferred as a result of destroying control below.



-- 
To view, visit https://gerrit.asterisk.org/10937
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I43d12b10045a98a8d42541889b85695be26f288a
Gerrit-Change-Number: 10937
Gerrit-PatchSet: 5
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 05 Feb 2019 16:12:05 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190205/01a701bf/attachment.html>