[Asterisk-code-review] force inline: remove all force inline from asterisk. (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/10939 )

Change subject: force_inline: remove all force_inline from asterisk.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/10939/1/include/asterisk/sem.h
File include/asterisk/sem.h:

https://gerrit.asterisk.org/#/c/10939/1/include/asterisk/sem.h@40
PS1, Line 40: /* These are thin wrappers; might as well inline them */
Remove comment.


https://gerrit.asterisk.org/#/c/10939/1/main/audiohook.c
File main/audiohook.c:

https://gerrit.asterisk.org/#/c/10939/1/main/audiohook.c@1472
PS1, Line 1472: #ifdef AST_DEVMODE
              : void _ast_assert(int condition, const char *condition_str, const char *file, int line, const char *function)
              : {
              : 	if (__builtin_expect(!condition, 1)) {
              : 		__ast_assert_failed(condition, condition_str, file, line, function);
              : 	}
              : }
              : #endi
This should be moved to utils.c not audiohook.c.  We'll never find it here. :)



-- 
To view, visit https://gerrit.asterisk.org/10939
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I2a90249763a7139fd12c54ad4e0e8d5cbbed14f9
Gerrit-Change-Number: 10939
Gerrit-PatchSet: 1
Gerrit-Owner: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Comment-Date: Tue, 05 Feb 2019 14:22:03 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: Yes
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190205/c629dff3/attachment.html>