[Asterisk-code-review] http.c: Support separated HTTP request (asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/10869 )

Change subject: http.c: Support separated HTTP request
......................................................................


Patch Set 5:

(2 comments)

Thank you for reviewing. I've fixed it. :)

https://gerrit.asterisk.org/#/c/10869/5/main/http.c
File main/http.c:

https://gerrit.asterisk.org/#/c/10869/5/main/http.c@90
PS5, Line 90: /*! Maximum response body length. */
> This comment is not accurate.
Right, fixed it. :)


https://gerrit.asterisk.org/#/c/10869/5/main/http.c@92
PS5, Line 92: #define INITIAL_RESPONSE_BODY_BUFFER 4096
> As the string can expand in size outside of this, do we need to allocate 4k? In most cases the respo […]
Agree. :) Fixed it to 1k. I think this would be good enough. :)



-- 
To view, visit https://gerrit.asterisk.org/10869
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I48a401aa64a21c3b37bf3cb4e0486d64b7dd8aa1
Gerrit-Change-Number: 10869
Gerrit-PatchSet: 5
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Michael L. Young <elgueromexicano at gmail.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Mon, 04 Feb 2019 21:00:26 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190204/78bca96b/attachment-0001.html>