[Asterisk-code-review] stasis.c: Added topic all container (asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/10929 )

Change subject: stasis.c: Added topic_all container
......................................................................


Patch Set 8:

(3 comments)

Thank you for reviewing. I've fixed it. :)

https://gerrit.asterisk.org/#/c/10929/8/include/asterisk/stasis.h
File include/asterisk/stasis.h:

https://gerrit.asterisk.org/#/c/10929/8/include/asterisk/stasis.h@539
PS8, Line 539:  */
> I think a note should be added that this SHOULD NOT be used in normal operation for publishing messa […]
Yes, I added comment. :)


https://gerrit.asterisk.org/#/c/10929/8/main/stasis.c
File main/stasis.c:

https://gerrit.asterisk.org/#/c/10929/8/main/stasis.c@488
PS8, Line 488: 	/* We have exclusive access to proxy and sorcery, no need for locking here. */
> sorcery isn't in use here
Fixed it. :)


https://gerrit.asterisk.org/#/c/10929/8/main/stasis.c@2252
PS8, Line 2252: static char *topic_complete_name(const char *word, int state)
> Nit: this is a private function so the state argument should be removed.
Removed it. :)



-- 
To view, visit https://gerrit.asterisk.org/10929
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie86d125d2966f93de74ee00f47ae6fbc8c081c5f
Gerrit-Change-Number: 10929
Gerrit-PatchSet: 8
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Mon, 04 Feb 2019 20:15:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190204/d3afb716/attachment.html>