[Asterisk-code-review] sounds: Sort 'core show sounds' output (asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/10953 )

Change subject: sounds: Sort 'core show sounds' output
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/10953/1/main/sounds.c
File main/sounds.c:

https://gerrit.asterisk.org/#/c/10953/1/main/sounds.c@177
PS1, Line 177: 		sorted = ao2_container_alloc_list(AO2_ALLOC_OPT_LOCK_NOLOCK, 0,
You might want to consider making this a rbtree container instead of a list.  There can be quite a lot of sounds.

IIRC on some systems it can be a ridiculous number.



-- 
To view, visit https://gerrit.asterisk.org/10953
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib39052a745040f75eb635f15a042da15b20e22ab
Gerrit-Change-Number: 10953
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 04 Feb 2019 20:08:13 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190204/7994f84c/attachment.html>