[Asterisk-code-review] netsock2: ast_addressfamily_to_sockaddrsize and ast_sockaddr_from_soc... (asterisk[13])

snuffy asteriskteam at digium.com
Sun Dec 22 23:25:33 CST 2019


snuffy has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13361 )

Change subject: netsock2: ast_addressfamily_to_sockaddrsize and ast_sockaddr_from_sockaddr.
......................................................................


Patch Set 5:

> Patch Set 5:
> 
> This compiles locally, and I'm not sure how to get into Jenkins to get the report as to why it failed ... some insight would be appreciated.


You can login to the Jenkins with the same as your gerrit/issues login.

Looking @ output from the jenkins shows this.

[2019-12-22T17:53:22.806Z]    [CC] smsq.c -> smsq.o
[2019-12-22T17:53:22.806Z] In file included from /srv/jenkins/workspace/asterisk-unittests_13/include/asterisk/json.h:22:0,
[2019-12-22T17:53:22.806Z]                  from /srv/jenkins/workspace/asterisk-unittests_13/include/asterisk/stasis.h:171,
[2019-12-22T17:53:22.806Z]                  from /srv/jenkins/workspace/asterisk-unittests_13/include/asterisk/channel.h:181,
[2019-12-22T17:53:22.806Z]                  from ael_main.c:24:
[2019-12-22T17:53:22.806Z] /srv/jenkins/workspace/asterisk-unittests_13/include/asterisk/netsock2.h:758:12: error: no previous prototype for '_ast_addressfamily_to_sockaddrsize' [-Werror=missing-prototypes]
[2019-12-22T17:53:22.806Z]  inline int _ast_addressfamily_to_sockaddrsize(int af, const char *file, int line, const char *func) {
[2019-12-22T17:53:22.806Z]             ^
[2019-12-22T17:53:22.806Z] cc1: all warnings being treated as errors


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13361
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Iee604e96e9096c79b477d6e5ff310cf0b06dae86
Gerrit-Change-Number: 13361
Gerrit-PatchSet: 5
Gerrit-Owner: Jaco Kroon <jaco at uls.co.za>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at sangoma.com>
Gerrit-CC: snuffy <snuffy22 at gmail.com>
Gerrit-Comment-Date: Mon, 23 Dec 2019 05:25:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191222/baa7c2b2/attachment.html>


More information about the asterisk-code-review mailing list