[Asterisk-code-review] json: Support older jansson versions. (asterisk[13])

Joshua C. Colp asteriskteam at digium.com
Tue Dec 17 08:15:05 CST 2019


Joshua C. Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13450 )

Change subject: json: Support older jansson versions.
......................................................................


Patch Set 2:

> Patch Set 1: Code-Review-1
> 
> The format string "o?" is used in the following files:
> * res/res_stasis_playback.c
> * res/res_stasis_recording.c
> * res/stasis/app.c
> 
> These need to be changed in 13 / 13.30.  One additional thought, should ast_json_vpack in 13.x assert that the format string does not contain any "?" or "*"?

It'd be a nice addition but I don't want to hold up 13.30 for it.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13450
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I6d596007ae85e8724d928865d99968f679be1142
Gerrit-Change-Number: 13450
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua C. Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Comment-Date: Tue, 17 Dec 2019 14:15:05 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191217/df91cc8b/attachment.html>


More information about the asterisk-code-review mailing list