[Asterisk-code-review] json: Support older jansson versions. (asterisk[16])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13474 )

Change subject: json: Support older jansson versions.
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> > Patch Set 1: Code-Review-1
> > 
> > The jansson >= 2.11 requirement was documented in UPGRADE.txt for 16.0.0 and above.  The configure script will not allow use of older jansson versions in ASterisk 16+.  The patch is valid for 13 and 13.30.
> 
> Is there a reason we still wouldn't include this? This code was present in the previous 16 code. It only landed in 16.4.0

Asterisk 16.0.0 blocks using versions of jansson which lack support for "s?" and the updated code is simpler.  The fact that "s?" wasn't added here until 16.4.0 doesn't matter, 16.0.0 requires the thread safety provided by jansson 2.11 so we can freely use any feature of 2.11.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13474
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I6d596007ae85e8724d928865d99968f679be1142
Gerrit-Change-Number: 13474
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua C. Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Comment-Date: Tue, 17 Dec 2019 13:57:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191217/8691fed8/attachment.html>