[Asterisk-code-review] app_chanisavail/cdr: ChanIsAvail sometimes fails to deactivate CDR. (asterisk[13])

[Frederic LE FOLL]

Frederic LE FOLL has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13472 )

Change subject: app_chanisavail/cdr: ChanIsAvail sometimes fails to deactivate CDR.
......................................................................


Patch Set 1:

(1 comment)

Sorry for this, I hoped I could fix module declaration for Asterisk 13 with an additional Patch Set, but I got a anthentication error whne trying to recover current asterisk-13 Gerrit work.

Redone from scratch for asterisk-13.

https://gerrit.asterisk.org/c/asterisk/+/13472/1/apps/app_chanisavail.c 
File apps/app_chanisavail.c:

https://gerrit.asterisk.org/c/asterisk/+/13472/1/apps/app_chanisavail.c@221 
PS1, Line 221: AST_MODULE_INFO(ASTERISK_GPL_KEY, AST_MODFLAG_DEFAULT, "Check channel availability",
             : 	.support_level = AST_MODULE_SUPPORT_EXTENDED,
             : 	.load = load_module,
             : 	.unload = unload_module,
             : 	.optional_modules = "func_cdr"
             : );
> This change in the patch should not be done on v13, because the functionality was put in in v16.
I know. I expected to do a "Checkout" from Gerrit and submit an additional Patch Set for asterisk-13 branch, but I get an Authentication failure when I run git fetch "https://<my alias>@gerrit.asterisk.org/a/asterisk" refs/changes/72/13472/1 && git checkout FETCH_HEAD.

Should I drop this Change Set and submit a separate Change Set from scrach for asterisk-13 ?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13472
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I1cbe09e8d2169c0962c1195133ff260d291f2074
Gerrit-Change-Number: 13472
Gerrit-PatchSet: 1
Gerrit-Owner: Frederic LE FOLL <frederic.lefoll at c-s.fr>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 16 Dec 2019 21:30:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191216/4c86cf36/attachment.html>