[Asterisk-code-review] res_pjsip_session: Set stream state on created streams for incoming SDP. (asterisk[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13447 )

Change subject: res_pjsip_session: Set stream state on created streams for incoming SDP.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13447/1/res/res_pjsip_session.c 
File res/res_pjsip_session.c:

https://gerrit.asterisk.org/c/asterisk/+/13447/1/res/res_pjsip_session.c@713 
PS1, Line 713: /* It is possible for SDP deferral to have already created a pending topology */
> Deferral hasn't been touched, so in certain cases it should still be possible for this to occur.

OK, maybe it's the comment's location that's confusing me.  The old code was doing a clone right after the comment which supported the comment.  The new code is doing a new alloc which doesn't seem to support the comment.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13447
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Ic5ae5a86437d3e686ac5afd91d133cc916198355
Gerrit-Change-Number: 13447
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua C. Colp <jcolp at sangoma.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Mon, 16 Dec 2019 17:18:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua C. Colp <jcolp at sangoma.com>
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191216/b066c207/attachment.html>