[Asterisk-code-review] feat: AudioSocket channel, application, and ARI support. (asterisk[master])

Seán C. McCord asteriskteam at digium.com
Fri Dec 13 21:25:28 CST 2019


Seán C. McCord has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11579 )

Change subject: feat: AudioSocket channel, application, and ARI support.
......................................................................


Patch Set 33:

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/11579/32/apps/app_audiosocket.c 
File apps/app_audiosocket.c:

PS32: 
> I'm still confused as to why we need the app when the dialplan could just Dial using the audiosocket […]
You're not wrong.  The cop-out answer I've been giving is that it's easier to use from the dialplan.  The real answer is just that it was written first.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11579
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ie866e6c4fa13178ec76f2a6971ad3590a3a588b5
Gerrit-Change-Number: 11579
Gerrit-PatchSet: 33
Gerrit-Owner: Seán C. McCord <ulexus at gmail.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Seán C. McCord <ulexus at gmail.com>
Gerrit-Comment-Date: Sat, 14 Dec 2019 03:25:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191213/d62d1800/attachment.html>


More information about the asterisk-code-review mailing list