[Asterisk-code-review] res_fax: wrap v21 detected Asterisk initiated negotiation with config... (asterisk[16])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13443 )

Change subject: res_fax: wrap v21 detected Asterisk initiated negotiation with config option
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> Should be better to fix "configured max datagram was not propagated"?
> Should the asterisk use configured endpoint option t38_udptl_maxdatagram while initiates negotiation?

Seemingly so, but from how the maxdatagram option was explained to me that's not how that option is suppose to work. It's suppose to only override a value specified in a remote's offer SDP. So in this instance, there is no SDP to override.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13443
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I5deb875f3485e20bc75119ec743090655d864a1a
Gerrit-Change-Number: 13443
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Comment-Date: Fri, 13 Dec 2019 21:00:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191213/f2940525/attachment.html>